content icon indicating copy to clipboard operation
content copied to clipboard

Add a helper script to add manifests and platform: versions for a new OCP release

Open jhrozek opened this issue 3 years ago • 11 comments

Description:

Each time we switch to a new OCP release, we tend to forget to add the new OCP release to the list of platforms for versioned rules and we also forget to add new versioned test manifests.

This is a simple and a little hackish script to do both.

Rationale:

  • So that we don't have to add new OCP versions manually

jhrozek avatar Jun 30 '22 10:06 jhrozek

Hello @jhrozek! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 9:1: E265 block comment should start with '# ' Line 24:10: E231 missing whitespace after ',' Line 32:100: E501 line too long (114 > 99 characters) Line 48:100: E501 line too long (127 > 99 characters) Line 93:1: E305 expected 2 blank lines after class or function definition, found 1

pep8speaks avatar Jun 30 '22 10:06 pep8speaks

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jun 30 '22 10:06 github-actions[bot]

Code Climate has analyzed commit b58fd7e2 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 5
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Jun 30 '22 10:06 codeclimate[bot]

Added CPE-AL label as a tracker, #8923 will make this script mostly obsolete.

evgenyz avatar Jun 30 '22 11:06 evgenyz

On Thu, Jun 30, 2022 at 04:01:34AM -0700, Evgeny Kolesnikov wrote:

Added CPE-AL label as a tracker, #8923 will make this script mostly obsolete.

Great, because this is really just a hack I wrote to add 4.11 support. Do I understand correctly that we will be able to use something like ocp4.10+? But we'll have to add the test manifests ourselves (this is the part of the script that might still be valid)

jhrozek avatar Jun 30 '22 11:06 jhrozek

On Thu, Jun 30, 2022 at 04:01:34AM -0700, Evgeny Kolesnikov wrote: Added CPE-AL label as a tracker, #8923 will make this script mostly obsolete. Great, because this is really just a hack I wrote to add 4.11 support. Do I understand correctly that we will be able to use something like ocp4.10+? But we'll have to add the test manifests ourselves (this is the part of the script that might still be valid)

No, you won't have to. platform: "os_linux[rhcos] >= 4.11" or ocp>=4.10 would be enough.

evgenyz avatar Jun 30 '22 12:06 evgenyz

@evgenyz but meanwhile, can we have this as a temporary solution?

jan-cerny avatar Jul 04 '22 09:07 jan-cerny

@evgenyz even with the context that the CPE AL won't be present in master very quickly?

jan-cerny avatar Jul 18 '22 15:07 jan-cerny

Codeclimate warnings seem legit, could you please check them out and fix them? Please see our coding style guide for justification: https://complianceascode.readthedocs.io/en/latest/manual/developer/04_style_guide.html#general-coding-style

matejak avatar Jul 29 '22 11:07 matejak

@evgenyz @matejak @jhrozek Any updates?

jan-cerny avatar Aug 17 '22 09:08 jan-cerny

@evgenyz @matejak @jhrozek Do you have any updates?

jan-cerny avatar Aug 24 '22 11:08 jan-cerny

Based on contributing guidelines https://github.com/ComplianceAsCode/content/blob/master/CONTRIBUTING.md we are closing this PR because of 30 days of inactivity. Feel free to reopen the PR if you wish to continue working on it.

jan-cerny avatar Sep 26 '22 13:09 jan-cerny