content icon indicating copy to clipboard operation
content copied to clipboard

Split build_yaml part 1

Open matejak opened this issue 2 years ago • 10 comments

Moved rule and platform functionality to separate files.

Only minimal modifications were made to the existing code - the PR is basically only about moving code around and about adjusting imports.

matejak avatar May 19 '22 08:05 matejak

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 19 '22 08:05 openshift-ci[bot]

Hello @matejak! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 42:100: E501 line too long (104 > 99 characters) Line 1298:29: W292 no newline at end of file

Line 53:100: E501 line too long (105 > 99 characters) Line 101:1: W293 blank line contains whitespace Line 245:36: W292 no newline at end of file

Line 94:20: W292 no newline at end of file

Line 122:100: E501 line too long (105 > 99 characters) Line 130:9: E303 too many blank lines (2) Line 295:100: E501 line too long (108 > 99 characters) Line 298:100: E501 line too long (116 > 99 characters) Line 539:24: W292 no newline at end of file

pep8speaks avatar May 19 '22 08:05 pep8speaks

Code Climate has analyzed commit 0f40caa9 and detected 80 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 16
Duplication 8
Style 56

Note: there are 2 critical issues.

View more on Code Climate.

codeclimate[bot] avatar May 19 '22 08:05 codeclimate[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

github-actions[bot] avatar May 19 '22 08:05 github-actions[bot]

@matejak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 05 '22 10:06 openshift-ci[bot]

@matejak there is a risk of getting more conflicts in future if somebody else would modify the same file

jan-cerny avatar Jun 13 '22 09:06 jan-cerny

@matejak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-stig-node 0f40caa9a0079ef417c77c65f460783652cdc566 link true /test e2e-aws-ocp4-stig-node
ci/prow/e2e-aws-ocp4-stig 0f40caa9a0079ef417c77c65f460783652cdc566 link true /test e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 21 '22 17:06 openshift-ci[bot]

@matejak any plans?

jan-cerny avatar Jun 29 '22 14:06 jan-cerny

I will probably return to it after the 0.1.63 upstream release.

matejak avatar Jul 21 '22 15:07 matejak

@matejak there is a risk of getting more conflicts in future if somebody else would modify the same file

jan-cerny avatar Aug 24 '22 12:08 jan-cerny

I will start with something less intrusive than moving rules - for instance, profiles are more suitable.

matejak avatar Sep 29 '22 08:09 matejak