content icon indicating copy to clipboard operation
content copied to clipboard
verified publisher icon ComplianceAsCode

[wip] Introduce /static-checks CI also for all Fedora versions

Open mildas opened this issue 1 year ago • 6 comments

Description:

Re-introduce static-checks, mainly rpmbuild-ctest, for all supported Fedora versions.

rpmbuild-ctest got necessary update related in https://github.com/RHSecurityCompliance/contest/pull/224 Now, it installs recommended packages to enable more unit tests.

Rationale:

Recently, one of our unit tests was failing on Fedora Rawhide and it was not caught by CI.

Review Hints:

See Testing Farm /static-checks Fedora jobs.

mildas avatar Jul 17 '24 12:07 mildas

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jul 17 '24 12:07 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12176 This image was built from commit: 373a9fbe8a9749868854425d5b3535d0a817a01f

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12176

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12176 make deploy-local

github-actions[bot] avatar Jul 17 '24 13:07 github-actions[bot]

@mildas Is the no space left on deviceproblem caused by the fact that we build every SSG product on Fedora?

jan-cerny avatar Jul 24 '24 07:07 jan-cerny

@jan-cerny Yes, from what I've checked it seems so

mildas avatar Jul 24 '24 12:07 mildas

/packit build

mildas avatar Aug 06 '24 13:08 mildas

@mildas What needs to be done to move this PR a long?

Mab879 avatar Aug 30 '24 18:08 Mab879

/packit build

Mab879 avatar Aug 30 '24 18:08 Mab879

/packit build

mildas avatar Sep 26 '24 08:09 mildas

@Mab879 Sorry, I completely forgot about this PR and didn't get notification about your ping. I will investigate what is going on with Fedora and try to fix it

mildas avatar Sep 26 '24 08:09 mildas

Problem related to rpmbuild fixed in Contest and PR description updated. Now it's ready for merge.

mildas avatar Sep 27 '24 07:09 mildas

Code Climate has analyzed commit 373a9fbe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Sep 27 '24 07:09 qlty-cloud-legacy[bot]