content icon indicating copy to clipboard operation
content copied to clipboard

Add Notes and Controls for SYS.1.6.A1-A4

Open sluetze opened this issue 1 year ago • 5 comments

Description:

This PR implements mostly notes and reuses some existing rules.

Rationale:

Customer asked for BSI Profile

Review Hints:

Currently the build is broken due to reference_type used. We have two control files (bsi_app_4_4 and bsi_sys_1_6 ) I configured both of them with reference_type: bsi expecting the autolabeling to “merge” the different requirements from the control files to the references. But this does not seem to work as expected. during the build the build fails with ValueError: Rule accounts_no_clusterrolebindings_default_service_account contains bsi reference, but this reference type is provided by bsi_sys_1_6 controls. Please remove the reference from rule.yml. even though the mentioned rule does not include a reference and also is not referenced in bsi_sys_1_6 control file changing the reference to another name results in unknown reference (ValueError: Unknown reference type bsi_sys) I suspect that the referencing is done for bsi_app_4_4 control file and afterwards the pre-check of the bsi_sys_1_6 for references fails.

sluetze avatar Jul 16 '24 11:07 sluetze

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 16 '24 11:07 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jul 16 '24 11:07 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12161 This image was built from commit: 32204e8ae32c7cfea2f21152a9de90588b7772ff

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12161

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12161 make deploy-local

github-actions[bot] avatar Jul 18 '24 12:07 github-actions[bot]

Code Climate has analyzed commit 32204e8a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jul 18 '24 13:07 qlty-cloud-legacy[bot]

QE: /lgtm

BhargaviGudi avatar Aug 14 '24 13:08 BhargaviGudi