content icon indicating copy to clipboard operation
content copied to clipboard

Extend the Profile class in profile_tool

Open marcusburghardt opened this issue 1 year ago • 3 comments

Description:

I had to conduct some tests with variables in profiles and it became much easier when this class was expanded to also map variables instead of only rules. It was actually considered when the class was introduced but there was no concrete demand for this back in the time. Now there is a demand for assessment of profiles variables.

Rationale:

Much easier to assess profiles.

Review Hints:

Some small tests to make sure the existing behavior of profile_tool is not changed should be enough. e.g.:

$ ./build-scripts/profile_tool.py most-used-rules --products rhel9

marcusburghardt avatar May 23 '24 09:05 marcusburghardt

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar May 23 '24 09:05 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12019 This image was built from commit: 67365a72c71787cc3c0bd544b268c1e666965cf4

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12019

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12019 make deploy-local

github-actions[bot] avatar May 23 '24 09:05 github-actions[bot]

Code Climate has analyzed commit 67365a72 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 23 '24 14:05 qlty-cloud-legacy[bot]