content icon indicating copy to clipboard operation
content copied to clipboard

OCP4: Fix e2e ci assertions

Open Vincent056 opened this issue 9 months ago • 10 comments

Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15

Align file-groupowner-ovn-db-files with https://github.com/ComplianceAsCode/content/pull/11861

Vincent056 avatar May 07 '24 15:05 Vincent056

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar May 07 '24 15:05 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11961 This image was built from commit: f32cacfd4da898b2cd623a4bce07c2105c513a40

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11961

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11961 make deploy-local

github-actions[bot] avatar May 07 '24 15:05 github-actions[bot]

Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15

Looks like we're including one update for 4.13, too.

rhmdnd avatar May 07 '24 16:05 rhmdnd

/test

rhmdnd avatar May 07 '24 16:05 rhmdnd

@rhmdnd: The /test command needs one or more targets. The following commands are available to trigger required jobs:

  • /test 4.13-e2e-aws-ocp4-cis
  • /test 4.13-e2e-aws-ocp4-cis-node
  • /test 4.13-e2e-aws-ocp4-e8
  • /test 4.13-e2e-aws-ocp4-high
  • /test 4.13-e2e-aws-ocp4-high-node
  • /test 4.13-e2e-aws-ocp4-moderate
  • /test 4.13-e2e-aws-ocp4-moderate-node
  • /test 4.13-e2e-aws-ocp4-pci-dss
  • /test 4.13-e2e-aws-ocp4-pci-dss-node
  • /test 4.13-e2e-aws-ocp4-stig
  • /test 4.13-e2e-aws-ocp4-stig-node
  • /test 4.13-e2e-aws-rhcos4-e8
  • /test 4.13-e2e-aws-rhcos4-high
  • /test 4.13-e2e-aws-rhcos4-moderate
  • /test 4.13-e2e-aws-rhcos4-stig
  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-e2e-aws-ocp4-cis
  • /test 4.15-e2e-aws-ocp4-cis-node
  • /test 4.15-e2e-aws-ocp4-e8
  • /test 4.15-e2e-aws-ocp4-high
  • /test 4.15-e2e-aws-ocp4-high-node
  • /test 4.15-e2e-aws-ocp4-moderate
  • /test 4.15-e2e-aws-ocp4-moderate-node
  • /test 4.15-e2e-aws-ocp4-pci-dss
  • /test 4.15-e2e-aws-ocp4-pci-dss-node
  • /test 4.15-e2e-aws-ocp4-stig
  • /test 4.15-e2e-aws-ocp4-stig-node
  • /test 4.15-e2e-aws-rhcos4-e8
  • /test 4.15-e2e-aws-rhcos4-high
  • /test 4.15-e2e-aws-rhcos4-moderate
  • /test 4.15-e2e-aws-rhcos4-stig
  • /test 4.15-images
  • /test 4.16-e2e-aws-ocp4-cis
  • /test 4.16-e2e-aws-ocp4-cis-node
  • /test 4.16-e2e-aws-ocp4-e8
  • /test 4.16-e2e-aws-ocp4-high
  • /test 4.16-e2e-aws-ocp4-high-node
  • /test 4.16-e2e-aws-ocp4-moderate
  • /test 4.16-e2e-aws-ocp4-moderate-node
  • /test 4.16-e2e-aws-ocp4-pci-dss
  • /test 4.16-e2e-aws-ocp4-pci-dss-node
  • /test 4.16-e2e-aws-ocp4-stig
  • /test 4.16-e2e-aws-ocp4-stig-node
  • /test 4.16-e2e-aws-rhcos4-e8
  • /test 4.16-e2e-aws-rhcos4-high
  • /test 4.16-e2e-aws-rhcos4-moderate
  • /test 4.16-e2e-aws-rhcos4-stig
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 07 '24 16:05 openshift-ci[bot]

/test 4.13-e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-cis-node /test 4.16-e2e-aws-ocp4-cis-node /test e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-high-node /test 4.16-e2e-aws-ocp4-high-node /test 4.15-e2e-aws-ocp4-moderate-node /test 4.16-e2e-aws-ocp4-moderate-node /test 4.13-e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-pci-dss-node /test 4.16-e2e-aws-ocp4-pci-dss-node /test e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-stig-node /test 4.16-e2e-aws-ocp4-stig-node

rhmdnd avatar May 07 '24 16:05 rhmdnd

All the failed results are due to file-permissions-cni-conf being set to PASS. Otherwise, all the results look clean.

rhmdnd avatar May 08 '24 00:05 rhmdnd

/test 4.13-e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-cis-node /test 4.16-e2e-aws-ocp4-cis-node /test e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-high-node /test 4.16-e2e-aws-ocp4-high-node /test 4.15-e2e-aws-ocp4-moderate-node /test 4.16-e2e-aws-ocp4-moderate-node /test 4.13-e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-pci-dss-node /test 4.16-e2e-aws-ocp4-pci-dss-node /test e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-stig-node /test 4.16-e2e-aws-ocp4-stig-node

Vincent056 avatar May 08 '24 06:05 Vincent056

/test 4.13-e2e-aws-ocp4-pci-dss-node

yuumasato avatar May 08 '24 14:05 yuumasato

Code Climate has analyzed commit f32cacfd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar May 08 '24 15:05 codeclimate[bot]

/test 4.13-e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-cis-node /test 4.16-e2e-aws-ocp4-cis-node /test e2e-aws-ocp4-cis-node /test 4.15-e2e-aws-ocp4-high-node /test 4.16-e2e-aws-ocp4-high-node /test 4.15-e2e-aws-ocp4-moderate-node /test 4.16-e2e-aws-ocp4-moderate-node /test 4.13-e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-pci-dss-node /test 4.16-e2e-aws-ocp4-pci-dss-node /test e2e-aws-ocp4-pci-dss-node /test 4.15-e2e-aws-ocp4-stig-node /test 4.16-e2e-aws-ocp4-stig-node

rhmdnd avatar May 08 '24 15:05 rhmdnd