content icon indicating copy to clipboard operation
content copied to clipboard

Fixed PAM configuration of pkcs11 module in common-auth file

Open alanmcanonical opened this issue 9 months ago • 4 comments

Description:

  • Corrected the ordering of modules to match the desired authentication sequence.

Rationale:

  • The current PAM configuration has an issue with the actions for pam_pkcs11 and pam_unix.

alanmcanonical avatar May 06 '24 12:05 alanmcanonical

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 06 '24 12:05 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar May 06 '24 12:05 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11945 This image was built from commit: f03ae18b9ed052327a815f47fd54d238eaac197c

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11945

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11945 make deploy-local

github-actions[bot] avatar May 06 '24 12:05 github-actions[bot]

Code Climate has analyzed commit f03ae18b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar May 06 '24 12:05 codeclimate[bot]

We need to rethink this as the proposed solution is not applicable to server image of Ubuntu 22.04.

mpurg avatar May 08 '24 10:05 mpurg