content icon indicating copy to clipboard operation
content copied to clipboard

increase coverage RHEL-08-010770 and RHEL-07-020710

Open vojtapolasek opened this issue 1 year ago • 4 comments

Description:

  • modify RHEL 7 and 8 STIG profile and use the file_permission_user_init_files_root rule instead of file_permission_user_init_files
  • also add appropriate variable so that all dot files are examined during the scan

Rationale:

  • increase STIG coverage
  • this was discovered during work on #11890

Review Hints:

build rhel7 and rhel8 products and examine stig and stig_gui profiles

vojtapolasek avatar Apr 25 '24 14:04 vojtapolasek

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Apr 25 '24 14:04 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11892 This image was built from commit: 5897559f627c50e14e489d964d4182b3bd72c4d3

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11892

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11892 make deploy-local

github-actions[bot] avatar Apr 25 '24 14:04 github-actions[bot]

/packit retest-failed

vojtapolasek avatar Apr 26 '24 12:04 vojtapolasek

@vojtapolasek what are the next steps on this?

I believe that my existing comments are still valid.

Mab879 avatar Jun 10 '24 15:06 Mab879

@Mab879 since rhel7 product is no longer in this repo, I modified the PR to include only rhel8 related changes.

vojtapolasek avatar Jun 20 '24 15:06 vojtapolasek

Code Climate has analyzed commit 5897559f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jun 20 '24 15:06 qlty-cloud-legacy[bot]