content icon indicating copy to clipboard operation
content copied to clipboard

add namespace parameter for cluster-test

Open sluetze opened this issue 1 year ago • 4 comments

Description:

this pr adds the ability to define a --namespace parameter for cluster-test in add_kubernetes_rule.py and defines "openshift-compliance" as default

Rationale:

while running ./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth there were sometimes empty results.

* Running scan with rule 'kube_descheduler_operator_exists'
> Output from last phase check: <no value> <no value>
[ ... ]
> Output from last phase check: <no value> <no value>
> Output from last phase check: <no value> <no value>
ERROR: Timeout waiting for scan to finish

this was caused by not switching to openshift-compliance namespace before running the command. To fix this I added a --namespace with openshift-compliance as default.

Review Hints:

deployments with non default namespace (not openshift-compliance) have a workflow impact. before: oc project $namespace ./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth

after: ./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth --namespace $namespace

sluetze avatar Apr 16 '24 13:04 sluetze

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 16 '24 13:04 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Apr 16 '24 13:04 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11824 This image was built from commit: 66f77d0cd1cc263e10be2b07298b18c26c1073b2

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11824

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11824 make deploy-local

github-actions[bot] avatar Apr 16 '24 13:04 github-actions[bot]

Code Climate has analyzed commit bc391cec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Apr 16 '24 13:04 qlty-cloud-legacy[bot]

Skipping Ansible hardening tests.

yuumasato avatar Jun 11 '24 20:06 yuumasato