Update ansible_playbook_to_role util for RHEL 9
Description:
Update ansible_playbook_to_role util for RHEL 9 Switch default branch from master to main Remove unsupported characters in role names during conversion process; i.e [ and ]
Rationale:
Util needs to be updated to support converting the ansible playbooks from this repo into ansible roles as has been done for RHEL 7 and RHEL 8.
Review Hints:
After building this main content repo, the following command is used to convert the playbooks into roles, which needs the added RHEL 9 support
./utils/ansible_playbook_to_role.py --product rhel9 --profile $p --organization RedHatOfficial --tag-release --token ${GIT_TOKEN} --build-playbooks-dir ./build/ansible/
I have used the updated version of the script for the last few content releases but did not have a chance until now to submit a PR.
Hi @dmc5179. Thanks for your PR.
I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Start a new ephemeral environment with changes proposed in this pull request:
Please resolve the merge conflicts by rebasing on the latest master.
:robot: A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11654
This image was built from commit: 0e3e3de964821256b79ce4f9a31a31c30c98e360
Click here to see how to deploy it
If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11654
Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11654 make deploy-local
Code Climate has analyzed commit f8034e94 and detected 5 issues on this pull request.
Here's the issue category breakdown:
| Category | Count |
|---|---|
| Style | 5 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 59.3% (0.0% change).
View more on Code Climate.
@Mab879 I'm not sure how to do that last part, remove the merge commit from this branch.
@Mab879 I'm not sure how to do that last part, remove the merge commit from this branch.
First all, thanks for the work.
Reviewing the changes I wondering if we can just close this PR.
The [DRAFT] to DRAFT change should no longer be needed as we now use "DRAFT - " as the prefix.
So that only leaves that print statement.
If you want that print statement, with all the recent changes it might be best just to open a new PR based on the latest master.
Again, thanks for the your work and happy to help out if you need it.
Thanks again for this PR.
However, I don't think the changes are necessary.
Please feel free to open a new PR to make additional changes.