content icon indicating copy to clipboard operation
content copied to clipboard

Image Pruner Rule has inconsistent ocil text

Open prb112 opened this issue 1 year ago • 5 comments

Image Pruner Rule has inconsistent ocil text

Description:

The text in the image pruner rule is inaccurate.

Rationale:

  • Rationale here. Replace this text. Don't use the italics format!

  • Fixes # Issue number here (e.g. #26) or remove this line if no issue exists.

Review Hints:

  • Review hints here. Replace this text. Don't use the italics format!

  • Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.

  • Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.

prb112 avatar Feb 26 '24 17:02 prb112

Hi @prb112. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 26 '24 17:02 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Feb 26 '24 17:02 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11627

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11627

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11627 make deploy-local

github-actions[bot] avatar Feb 26 '24 19:02 github-actions[bot]

/lgtm By default the suspend is false. If you udpadate the imagepruners.imageregistry.operator.openshift.io/cluster as below, you can see the imagepruner jobs will be triggered every minute.

% oc get imagepruners.imageregistry.operator.openshift.io/cluster -o jsonpath='{.spec}{"\n"}'                                               
{"failedJobsHistoryLimit":1,"ignoreInvalidImageReferences":true,"keepTagRevisions":1,"logLevel":"Normal","schedule":"* * * * *","successfulJobsHistoryLimit":1,"suspend":false}

$ oc get rule upstream-ocp4-image-pruner-active -o=jsonpath={.instructions} Ensure that the imagepruner is configured and is not in a suspended state. oc get imagepruners.imageregistry.operator.openshift.io/cluster -o jsonpath='{.spec}{"\n"}'.spec.suspend field should be set to false.

xiaojiey avatar Mar 04 '24 08:03 xiaojiey

/unhold

xiaojiey avatar Mar 04 '24 08:03 xiaojiey

This is just a change in ocil text, skipping the hardening tests. Merging

yuumasato avatar Jun 04 '24 11:06 yuumasato