content
content copied to clipboard
OCP4: Add workflow to test ocp content
Add this workflow so we can test ocp4 content can be parsed on each PR
https://github.com/ComplianceAsCode/compliance-operator/pull/493 needs to merge before this can work
Start a new ephemeral environment with changes proposed in this pull request:
:robot: A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11615
This image was built from commit: 894dfa96c30f2ac64223fb11da62fcca64bc4a4d
Click here to see how to deploy it
If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11615
Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11615 make deploy-local
Checking whether the compliance-operator can parse the data stream is important, but the test in https://github.com/ComplianceAsCode/compliance-operator/pull/493/files# seem too specific and contained.
I wonder if we could have a more thorough "smoke" integration test, something that runs CO and consumes the data stream.
Checking whether the compliance-operator can parse the data stream is important, but the test in https://github.com/ComplianceAsCode/compliance-operator/pull/493/files# seem too specific and contained.
I wonder if we could have a more thorough "smoke" integration test, something that runs CO and consumes the data stream.
the reason for this one I think is to have some gating on if CO can parse the datastream, but not to run a full on CI e2e job, however I think we can improve the test here
Looks like this is on the right track. Just some feedback on isolating the test implementation details to the compliance-operator code base, so that the content repository doesn't need to understand how the test is implemented to call it.
thanks for the review, just had those tests changed to use the make target instead.
Code Climate has analyzed commit 894dfa96 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 58.1% (-1.1% change).
View more on Code Climate.
/retest
This PR is adding a new GH workflow, there is no need to rebase to trigger hardening tests.