content icon indicating copy to clipboard operation
content copied to clipboard

Fix TypeError in get_implemented_stigs

Open svet-se opened this issue 1 year ago • 9 comments

Description:

  • Fix TypeError

Rationale:

  • Fix TypeError: unhashable type: 'list'. As refs is a list we do not need this snippet

svet-se avatar Feb 16 '24 11:02 svet-se

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 16 '24 11:02 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Feb 16 '24 11:02 github-actions[bot]

@jan-cerny please review this fix as you worked on ssg.build_yaml.Rule.from_yaml

Have a nice day! Thanks!

svet-se avatar Feb 16 '24 11:02 svet-se

/packit retest-failed

Mab879 avatar Feb 16 '24 13:02 Mab879

/packit retest-failed

Mab879 avatar Feb 16 '24 13:02 Mab879

/packit rebuild-failed

Mab879 avatar Feb 16 '24 14:02 Mab879

/packit retest-failed

Mab879 avatar Feb 16 '24 17:02 Mab879

/packit retest-failed

One more time. Based on the logs this looks like possible Infra fail. Otherwise a rebase might be necessary.

Mab879 avatar Feb 16 '24 18:02 Mab879

@svet-se Can you please rebase this PR on the latest master?

Mab879 avatar Feb 20 '24 13:02 Mab879

@Mab879 done

svet-se avatar Feb 20 '24 14:02 svet-se

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11596

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11596

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11596 make deploy-local

github-actions[bot] avatar Feb 20 '24 14:02 github-actions[bot]

Code Climate has analyzed commit 1187d864 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Feb 20 '24 14:02 qlty-cloud-legacy[bot]