content icon indicating copy to clipboard operation
content copied to clipboard

Add ansible remediation for audispd plugin UBTU-20-010216

Open dexterle opened this issue 1 year ago • 10 comments

Description:

  • Fix UBTU-20-010216
  • Add Ansible remediation for Ubuntu

Rationale:

  • Part of Ubuntu 20.04 DISA STIG v1r9 profile upgrade
  • https://github.com/ComplianceAsCode/content/pull/10738

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010216"

To test changes with bash, run the remediation sections: xccdf_org.ssgproject.content_rule_auditd_audispd_configure_remote_server

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform a manual check given the check text. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

dexterle avatar Sep 08 '23 15:09 dexterle

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 08 '23 15:09 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Sep 08 '23 17:09 github-actions[bot]

Code Climate has analyzed commit f214a16d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.9%.

View more on Code Climate.

codeclimate[bot] avatar Sep 28 '23 15:09 codeclimate[bot]

@dexterle @dodys Do you plan to continue working on this PR?

jan-cerny avatar Nov 02 '23 13:11 jan-cerny

@dexterle @dodys Do you plan to continue working on this PR?

I sent a message to dexterle on gitter last week to get some feedback, if we don't hear anything until November 13th, then we will start adding the missing bits on top of the open PRs.

dodys avatar Nov 02 '23 17:11 dodys

@dodys I was able to get in touch with a colleague who more recently spoke with @dexterle and they mentioned that they are focusing on other personal matters so if you all wouldn't mind helping taking the handful of open pull requests to the finish line I'd really appreciate it. Unfortunately these days I don't have any time to help personally but will continue to direct folks to help out.

It's also worth noting that I have been doing my best to get vendors to contribute directly and have seen some success with SUSE so I'm focused on Canonical this next year.

aghassemlouei avatar Dec 01 '23 16:12 aghassemlouei

@dodys I was able to get in touch with a colleague who more recently spoke with @dexterle and they mentioned that they are focusing on other personal matters so if you all wouldn't mind helping taking the handful of open pull requests to the finish line I'd really appreciate it. Unfortunately these days I don't have any time to help personally but will continue to direct folks to help out.

It's also worth noting that I have been doing my best to get vendors to contribute directly and have seen some success with SUSE so I'm focused on Canonical this next year.

thanks for the heads up, I spoke with Dexter a month ago and we will be continuing his work. @mpurg is currently on it and already provided one PR #11325

dodys avatar Dec 01 '23 17:12 dodys

/packit test

marcusburghardt avatar Dec 04 '23 10:12 marcusburghardt

c

Appreciate your efforts @dodys and @mpurg; as we start ramping back up post-holidays we'll have more engineers contributing and supporting the project.

aghassemlouei avatar Dec 08 '23 22:12 aghassemlouei

Could you resolve the conflict, please?

marcusburghardt avatar Apr 18 '24 09:04 marcusburghardt

@dexterle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-images f214a16dcc242496a10f441a11328f8e41d10cc9 link true /test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 30 '24 16:07 openshift-ci[bot]

ping

jan-cerny avatar Aug 02 '24 05:08 jan-cerny

dexterle reached out last week about continuing work on this PRs, and I've asked to open new ones for a clean state. Therefore closing this one.

dodys avatar Aug 02 '24 06:08 dodys