content icon indicating copy to clipboard operation
content copied to clipboard

Fix rule ubtu 20 010070

Open dexterle opened this issue 1 year ago • 4 comments

Description:

  • Add UBTU-20-010070
  • Modify Ansible remediation to include ubuntu 2004
  • Deprecate ubuntu.xml to use modified shared.xml OVAL definition

Rationale:

  • Part of Ubuntu 20.04 DISA STIG v1r9 profile upgrade
  • https://github.com/ComplianceAsCode/content/pull/10738

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010070"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_remember

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform a manual test given the check text. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

dexterle avatar Sep 07 '23 20:09 dexterle

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 07 '23 20:09 openshift-ci[bot]

see feedback: https://github.com/ComplianceAsCode/content/pull/10738/commits/2559ba58e0b32fbd4537f2d071bcd98fb95ccf2f#r1319023020 https://github.com/ComplianceAsCode/content/pull/10738/commits/9276622bb4f14a0ed614920d832ecb619b6287f3#r1319021942

dexterle avatar Sep 07 '23 20:09 dexterle

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Sep 07 '23 22:09 github-actions[bot]

Code Climate has analyzed commit 1f6c9c32 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Sep 13 '23 17:09 codeclimate[bot]

@dexterle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-images 1f6c9c327b8e3e0cc493d6eb772d45c74baeffa9 link true /test 4.12-images
ci/prow/4.17-images 1f6c9c327b8e3e0cc493d6eb772d45c74baeffa9 link true /test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 30 '24 16:07 openshift-ci[bot]

ping

jan-cerny avatar Aug 02 '24 05:08 jan-cerny

dexterle reached out last week about continuing work on this PRs, and I've asked to open new ones for a clean state. Therefore closing this one.

dodys avatar Aug 02 '24 06:08 dodys