ComplianceAsCode
CMP-3775: Enhance TestSingleScanSucceeds to cover 27649 logic
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Enhance TestSingleScanSucceeds to cover 27649 logic
=== NAME TestSingleScanSucceeds
main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage)
main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f
--- PASS: TestSingleScanSucceeds (93.70s)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xiaojiey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [xiaojiey]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@xiaojiey: This pull request references CMP-3775 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:994-95522622d2a962b85e0f8223a8f0451953e53b80
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@xiaojiey: No Jira issue with key CMP-27649 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.
In response to this:
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Enhance TestSingleScanSucceeds to cover 27649 logic
=== NAME TestSingleScanSucceeds main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage) main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f --- PASS: TestSingleScanSucceeds (93.70s)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3775 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
In response to this:
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Enhance TestSingleScanSucceeds to cover 27649 logic
=== NAME TestSingleScanSucceeds main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage) main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f --- PASS: TestSingleScanSucceeds (93.70s)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: No Jira issue with key CMP-27649 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.
In response to this:
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Add exit-code check for Compliance/NonCompliance test result:
=== NAME TestSingleScanSucceeds main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage) main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f --- PASS: TestSingleScanSucceeds (93.70s)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3775 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
In response to this:
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Add exit-code check for Compliance/NonCompliance test result:
=== NAME TestSingleScanSucceeds main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage) main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f --- PASS: TestSingleScanSucceeds (93.70s)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3775 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
This pull request references CMP-3783 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
In response to this:
- Use https://github.com/ComplianceAsCode/compliance-operator/pull/960 to include the required selectors to machineconfig to pass the ValidatingAdmissionPolicy;
- Add exit-code check for Compliance/NonCompliance test result:
=== NAME TestSingleScanSucceeds main_test.go:689: Verifying scan exit code in configmap (OCP-27649 coverage) main_test.go:708: Successfully verified exit code 0 in configmap openscap-pod-42ff9dd4f8bfb8b8590efd45f560bbdf7328590f --- PASS: TestSingleScanSucceeds (93.70s)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:994-800c8b2ff56291d7498eb3e56ccb65e925a197fb
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:994-30d74aeae5b533172acd1fd78483ed8900de0a21
@xiaojiey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-rosa | 30d74aeae5b533172acd1fd78483ed8900de0a21 | link | true | /test e2e-rosa |
| ci/prow/e2e-aws-serial | 30d74aeae5b533172acd1fd78483ed8900de0a21 | link | true | /test e2e-aws-serial |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
I have added and removed /lgtm label as I am not sure who else needs to see and approve this PR and I was afraid I might be the cause of accidental merging before relevant people review. Please let me know if I should add the label again
