ComplianceAsCode
OCPBUGS-38213: Use the variables in actual checks
Previously, at the scan phase the variable was not actually being used to evaluating the rule PASS or FAIL. In this PR, read the variable to evaluate the rule PASS or FAIL.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xiaojiey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [xiaojiey]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@xiaojiey: This pull request references Jira Issue OCPBUGS-38213, which is invalid:
- expected the bug to target the "4.19.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Previously, at the scan phase the variable was not actually being used to evaluating the rule PASS or FAIL. In this PR, read the variable to evaluate the rule PASS or FAIL.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.
In response to this:
Previously, at the scan phase the variable was not actually being used to evaluating the rule PASS or FAIL. In this PR, read the variable to evaluate the rule PASS or FAIL.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references Jira Issue OCPBUGS-38213, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xiaojiey
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Previously, at the scan phase the variable was not actually being used to evaluating the rule PASS or FAIL. In this PR, read the variable to evaluate the rule PASS or FAIL.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: xiaojiey.
Note that only ComplianceAsCode members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
@xiaojiey: This pull request references Jira Issue OCPBUGS-38213, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xiaojiey
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Previously, at the scan phase the variable was not actually being used to evaluating the rule PASS or FAIL. In this PR, read the variable to evaluate the rule PASS or FAIL.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:711-ee3f552978cdb0cb945d4dff062f3409b6143857
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}