ComplianceAsCode
OCPBUGS-42396: Fix variables not listed in the annotations of rule issue
@xiaojiey: This pull request references Jira Issue OCPBUGS-42396, which is invalid:
- expected the bug to target the "4.19.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-0bf00f44288d480ffe218711099532e47190a1ef
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-cf6711c5712956fb67e6eb491237606a145a15d9
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-6081872ebc2b6dd6ef4da0c2ab6ad73c84568547
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-a6f27023a95b24be015a9a79d8c552cd34c6cc4f
I can see the variable is listed correctly with catalogsource image ghcr.io/complianceascode/compliance-operator-catalog:706-a6f27023a95b24be015a9a79d8c552cd34c6cc4f
% oc get rule ocp4-resource-requests-limits-in-daemonset -o=jsonpath='{.metadata.annotations.compliance\.openshift\.io/rule-variable}'
var-daemonset-limit-namespaces-exempt-rege
Verification passed with 4.19.0-0.nightly-2025-03-21-030708 + PR #706 code This PR fixes both OCPBUGS-42396 and OCPBUGS-35260
$ oc get rule -o custom-columns=NAME:metadata.name,VARIABLE:metadata.annotations.compliance\\.openshift\\.io/rule-variable --no-headers | grep ocp4-configure-network-policies-namespaces
ocp4-configure-network-policies-namespaces var-network-policies-namespaces-exempt-regex
$ oc get rule -o custom-columns=NAME:metadata.name,VARIABLE:metadata.annotations.compliance\\.openshift\\.io/rule-variable --no-headers | grep resource-requests-limits
ocp4-resource-requests-limits-in-daemonset var-daemonset-limit-namespaces-exempt-regex
ocp4-resource-requests-limits-in-deployment var-deployment-limit-namespaces-exempt-regex
ocp4-resource-requests-limits-in-statefulset var-statefulset-limit-namespaces-exempt-regex
@xiaojiey: This pull request references Jira Issue OCPBUGS-42396, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xiaojiey
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: xiaojiey.
Note that only ComplianceAsCode members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
@xiaojiey: This pull request references Jira Issue OCPBUGS-42396, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xiaojiey
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-a79aff67ca5df2c8e01467391fb5d3098a78b5a9
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-99073bbcc32443c377a9aa9ffd6b1a6a07cac92e
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-bb68efb9841a651f9aa6cc5c770eb1dac051a1a7
:robot: To deploy this PR, run the following command:
make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:706-4c4363975510de605a688075e28ce6e10a03d31c
@xiaojiey: This pull request references Jira Issue OCPBUGS-42396, which is invalid:
- expected the bug to target the "4.21.0" version, but no target version was set
- expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is In Progress instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
The main changes are:
- Extract Variables from Rule Warnings
- Improve Variable Extraction Efficiency. Enhanced trimToValue() function to deduplicate variables at the source.
- Add a e2e test for the variables check in the annotation.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3557 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.
In response to this:
The main changes are:
- Extract Variables from Rule Warnings
- Improve Variable Extraction Efficiency. Enhanced trimToValue() function to deduplicate variables at the source.
- Add a e2e test for the variables check in the annotation.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3582 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.
In response to this:
The main changes are:
- Extract Variables from Rule Warnings
- Improve Variable Extraction Efficiency. Enhanced trimToValue() function to deduplicate variables at the source.
- Add a e2e test for the variables check in the annotation.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@xiaojiey: This pull request references CMP-3582 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.
This pull request references CMP-3557 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.
In response to this:
The main changes are:
- Extract Variables from Rule Warnings
- Improve Variable Extraction Efficiency. Enhanced trimToValue() function to deduplicate variables at the source.
- Add a e2e test for the variables check in the annotation.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Verification passed with CO installed from this PR.
$ oc get rule -o custom-columns=NAME:metadata.name,VARIABLE:metadata.annotations.compliance\\.openshift\\.io/rule-variable --no-headers | grep ocp4-configure-network-policies-namespaces
ocp4-configure-network-policies-namespaces var-network-policies-namespaces-exempt-regex
$ oc get rule -o custom-columns=NAME:metadata.name,VARIABLE:metadata.annotations.compliance\\.openshift\\.io/rule-variable --no-headers | grep resource-requests-limits
ocp4-resource-requests-limits-in-daemonset var-daemonset-limit-namespaces-exempt-regex
ocp4-resource-requests-limits-in-deployment var-deployment-limit-namespaces-exempt-regex
ocp4-resource-requests-limits-in-statefulset var-statefulset-limit-namespaces-exempt-regex
Also I have run test cases OCP-33578, 33859, 47044, 42720 on my cluster to look for regressions and it has all passed
@Anna-Koudelkova: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.