DCA icon indicating copy to clipboard operation
DCA copied to clipboard

Additional improvements to Json IO

Open PDoakORNL opened this issue 4 years ago • 0 comments

With regards to the life cycle of the object, RAII could be better. If we're going to throw for a bad file and the purpose of close file is it to prepare for another open... It seems be better to just have the file as a constructor argument and do no "reseting" closing the file in the destructor.

With regards to repeated tags, that seems like invalid input and an exception should be thrown.

PDoakORNL avatar Dec 15 '20 17:12 PDoakORNL