dotnet icon indicating copy to clipboard operation
dotnet copied to clipboard

ISettingsStorageHelper namespace incorrect

Open michael-hawker opened this issue 3 years ago • 1 comments

Describe the bug

Not sure how this was missed, but the ISettingsStorageHelper has a different namespace than all the other helpers here:

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/ISettingsStorageHelper.cs#L5

All the other helpers are CommunityToolkit.Common.Helpers...

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/IFileStorageHelper.cs#L8

Similarly the extension helper to it has a .Extensions:

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Extensions/ISettingsStorageHelperExtensions.cs#L8

Where the other extensions do not and are just part of CT.Common.

Regression

No response

Steps to reproduce

N/A Code Quality

Expected behavior

Consistency in Namespace

Screenshots

No response

IDE and version

VS 2022

IDE version

No response

Nuget packages

  • [X] CommunityToolkit.Common
  • [ ] CommunityToolkit.Diagnostics
  • [ ] CommunityToolkit.HighPerformance
  • [ ] CommunityToolkit.Mvvm (aka MVVM Toolkit)

Nuget package version(s)

8.0.0

Additional context

Not sure if there's other places to audit?

Help us help you

Yes, but only if others can assist

michael-hawker avatar Aug 25 '22 22:08 michael-hawker

Looks like it was introduced here as part of the transfer from the WCT:

https://github.com/CommunityToolkit/dotnet/commit/8b7c87284b05eaa1d4bce7452ed534b38b36df36#diff-e8b2ffe244c59c6c54d9a996f892c8190d6b25f91e9d4880688e72536e322f4fL7

I just noticed this migrating the WinUI branch of the Toolkit on top of the 8.0.0 .NCT release...

image

michael-hawker avatar Aug 25 '22 22:08 michael-hawker