WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

fix(DataGrid): tabbing doesnt properly bring cell into view, when cell expanded in edit-mode

Open Xiaoy312 opened this issue 2 months ago • 0 comments

Fixes #4983

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When moving to the next cell using Tab and this cell's size changing from entering edit-mode, the scroll-into-view is performed based on its previous size from the normal-mode.

What is the new behavior?

The scroll-into-view is performed again, if the cell size grows within a short time frame.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [x] Based off latest main branch of toolkit
  • [x] Tested code with current supported SDKs
  • [ ] New component
    • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
    • [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • [ ] If control, added to Visual Studio Design project
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [ ] New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [x] Contains NO breaking changes

Other information

related: https://github.com/unoplatform/uno/issues/14311

Xiaoy312 avatar Apr 23 '24 18:04 Xiaoy312