WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

AdvancedCollectionView ArgumentOutOfRangeException fixed, or at least improved

Open myblindy opened this issue 1 year ago • 3 comments

Fixes

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

AdvancedCollectionView crashes with ArgumentOutOfRangeException with live shaping (filtering).

What is the new behavior?

One less crash.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [X] Based off latest main branch of toolkit (specifically, the winui branch)
  • [X] Tested code with current supported SDKs
  • [ ] New component
    • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
    • [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • [ ] If control, added to Visual Studio Design project
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [ ] New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [X] Contains NO breaking changes

Other information

Closes #4813

myblindy avatar Dec 07 '22 16:12 myblindy