WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

Change `CacheBase.GetCacheFileName` to virtual method

Open Scighost opened this issue 1 year ago • 1 comments

Fixes

#4768

Change CacheBase.GetCacheFileName to virtual method, letting developer can custom cache file name.

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

CacheBase.GetCacheFileName is a static method and cannot be changed.

What is the new behavior?

Developer can override this method.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [x] Based off latest main branch of toolkit
  • [x] Tested code with current supported SDKs
  • [ ] New component
    • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
    • [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • [ ] If control, added to Visual Studio Design project
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [ ] New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [x] Contains NO breaking changes

Other information

Scighost avatar Sep 17 '22 04:09 Scighost

Thanks Scighost for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

msftbot[bot] avatar Sep 17 '22 04:09 msftbot[bot]