WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

Fixed ImageCropper AspectRatio not updating on image load

Open Arlodotexe opened this issue 2 years ago • 1 comments

Fixes #4483 #4478

Closes #4482

Fixed an issue where Aspect Ratio of the image cropper wouldn't update after the image is loaded.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Image cropper doesn't update the aspect ratio when the image is loaded.

What is the new behavior?

Aspect ratio updates correctly when image is loaded.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [x] Based off latest main branch of toolkit
  • [ ] Tested code with current supported SDKs
  • [ ] New component
    • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
    • [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • [ ] If control, added to Visual Studio Design project
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [ ] New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [x] Contains NO breaking changes

Other information

Arlodotexe avatar Aug 11 '22 21:08 Arlodotexe

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

ghost avatar Aug 11 '22 21:08 ghost