WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

Adding conditional tooltip class

Open dpaulino opened this issue 2 years ago • 3 comments

Fixes

Fixes #4199.

This feature adds an attached property that can conditionally enable or disable a tooltip. This is useful for a11y scenarios, such as when a textblock gets trimmed due to 225% text scale, this conditional tooltip can be activated when the target element is trimmed. Thus, a tooltip would be shown only when the textblock is trimmed.

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

None

What is the new behavior?

New feature

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Tested code with current supported SDKs
  • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [x] New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [x] Contains NO breaking changes

Other information

dpaulino avatar Aug 30 '21 04:08 dpaulino

Thanks dpaulino for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

ghost avatar Aug 30 '21 04:08 ghost

@dpaulino is this something you still wanted to clean-up and contribute?

michael-hawker avatar Jan 19 '22 17:01 michael-hawker

Yes! sorry I've been busy outside work and forgot this. I'll try to get to it this weekend

dpaulino avatar Jan 20 '22 03:01 dpaulino