WindowsCommunityToolkit icon indicating copy to clipboard operation
WindowsCommunityToolkit copied to clipboard

InappNotification - Severity Level

Open Pinox opened this issue 4 years ago • 8 comments

Hi Guys,

Currently the inappnotification control for VSCodeNotificationStyle simply displays an "blue" info tag eg.

image

It would be useful if this control is in sync with the InfoBar control in WinUI 3.0 where you can pass the severity level.

image

eg.

ExampleInAppNotification.Show("Some text.", duration , severitylevel , severitycolor);

Pinox avatar Mar 31 '21 07:03 Pinox

Hello, 'Pinox! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

ghost avatar Mar 31 '21 07:03 ghost

Thanks @Pinox, I believe our plan is to swap out the internal display of the InAppNotification with an actual InfoBar, so when that happens we should just expose the InfoBar's property for this.

michael-hawker avatar Mar 31 '21 17:03 michael-hawker

thanks @michael-hawker .

The infobar does not have a display duration therefor me raising this enhancement for inappnotification. Will display duration then be added to infobar to bring feature parity with inappnotifications ?

Pinox avatar Mar 31 '21 18:03 Pinox

@Pinox I think they're thinking about it in WinUI, but not sure. So until they do, we'll keep the InAppNotification around. I'm just saying we'll swap out the internals of its template to just be a wrapper around InfoBar itself rather than having a whole custom style.

michael-hawker avatar Mar 31 '21 20:03 michael-hawker

Happy to leave this open for tracking.

michael-hawker avatar Apr 01 '21 19:04 michael-hawker

@vgromfeld is this something you'd need? I was thinking we'd just have InAppNotification use an InfoBar internally and then we could just expose the Severity property.

michael-hawker avatar Jun 29 '21 17:06 michael-hawker

I don't have this need yet 😊, but I agree that we can use InfoBar as the base brick for the InAppNotificationControl.

InfoBar has an IsIconVisible property to control if the Severity indicator should be displayed or not. I guess we should also have it if we add the Severity support.

vgromfeld avatar Jun 30 '21 09:06 vgromfeld

Thanks @vgromfeld I'll leave these in the milestone then and we'll see if you or someone picks them up before we ship.

michael-hawker avatar Jun 30 '21 17:06 michael-hawker