CommunityToolkit
Use GitHub Actions diagnostics flag in CI
Using the guidance in https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging, this PR disables verbose diagnostic logging in CI except when "Enable Debug Logging" is checked on a rerun.
Found an issue:
The workflow is not valid. .github/workflows/build.yml (Line: 21, Col: 23): Unrecognized named-value: 'env'. Located at position 1 within expression: env.ACTIONS_RUNNER_DEBUG
Docs aren't specific about which variable this is stored in, a search on github suggested env but this seems to not be the case. Will try github instead.
That's odd, the random test failure we usually only see on WinUI 3 has happened on UWP now:
The active test run was aborted. Reason: Unable to communicate with test host process.
Closing app with package full name '7af355f7-0c20-4a39-9b71-8cf779ccfa82_1.0.0.0_x64__1v6rh0sdhj24c'.
Results File: C:\a\Windows\Windows\TestResults\UWP.trx
The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred:
ConvertersExperiment.Tests.Test_BoolToObjectConverter.Test_ConvertBackCollapseWithNegateTrue
Linking #347 and rerunning.
Yeah, so was just checking, it shows up with a confirmation dialog for failed jobs:
And all jobs:
I'm going to cancel this current run, then re-kick it with the toggle enabled so we can compare the two runs and check it's working as intended. 😊
Kicked off here: https://github.com/CommunityToolkit/Windows/actions/runs/9896968654 - looking good so far, will see if it picks that up from the env, will be nice to see that off by default to get some brevity back in our builds. We can at least use this to further tweak the amount of output we do too in the future. Nice!
@Arlodotexe so I see the debug info from GitHub, but it didn't seem to enable the flag?
It also feels like even when it's off the msbuild details are pretty huge, should we be minimal by default and on normal or detailed or something when the flag is on?
@Arlodotexe WinUI 3 tests failed, I'll ask some folks what we can do or who we can ask for more assistance in root causing that for them.
Doesn't look like that flag did anything, though not sure if once checked it remains checked? Or did you kick off a run with it?
Otherwise, we should try the other runner context
That's odd, I guess docs are outdated? Error message from last run:
[Invalid workflow file: .github/workflows/build.yml#L23](https://github.com/CommunityToolkit/Windows/actions/runs/10085654064/workflow)
The workflow is not valid. .github/workflows/build.yml (Line: 23, Col: 23): Unrecognized named-value: 'runner'. Located at position 1 within expression: runner.debug