CommunityToolkit
Problems with InternalsVisibleTo
Worth noting our use of InternalsVisibleTo are using or being used by same set of components that keep appearing in these issues-- Behaviors, Animations, Media and Extensions.
If our use of InternalsVisibleTo is indeed related to our AoT issues on Wasdk as well as what we've seen here regarding transient dependencies, it might be highlighting a deeper issue with how we've set up these libraries.
We might want to go through and see if we can remove the need for these InternalsVisibleTo, it looks like at least a few are just to avoid helper duplication. If it fixes any of the issues we've listed throughout this ticket, we've narrowed the scope of our search down considerably.
Originally posted by @Arlodotexe in https://github.com/CommunityToolkit/Windows/issues/169#issuecomment-2181688627
Adding additional details highlighted in #446:
We're testing these changes for three reasons:
- https://github.com/CommunityToolkit/Windows/issues/169#issuecomment-2181688627
- https://github.com/CommunityToolkit/Windows/pull/404
- ~~https://github.com/CommunityToolkit/Tooling-Windows-Submodule/pull/195~~
The third reason is dismissed, https://github.com/CommunityToolkit/Tooling-Windows-Submodule/pull/195#issuecomment-2204276472 helped us verify that it was unrelated, and the fix offered by Mano and yourself @Sergio0694 double confirms that.
The first two are still a possible concern. If we can verify that the use of InternalsVisibleTo here isn't uncovering some platform bug causing #169, we can dismiss that as well and close this PR without merging.