Windows icon indicating copy to clipboard operation
Windows copied to clipboard
verified publisher icon CommunityToolkit

SettingsExpander sub controls have same accessible name and localized control type

Open guimafelipe opened this issue 1 year ago • 1 comments

Describe the bug

The SettingsExpander control have an accessibility issue on its internal controls. The accessible names on them are the same and they are stacked (one is child of the other). This creates a accessibility issue reported by the Accessibility Insights for Windows tool.

Steps to reproduce

Create a SettingsExpander control. Give it a Title and Description. 
Run Accessibility Insights for Windows and inspect the control.

Expected behavior

No accessibility issues found.

Screenshots

Example 1: image image image Example 2: image image image

Code Platform

  • [ ] UWP
  • [X] WinAppSDK / WinUI 3
  • [ ] Web Assembly (WASM)
  • [ ] Android
  • [ ] iOS
  • [ ] MacOS
  • [ ] Linux / GTK

Windows Build Number

  • [ ] Windows 10 1809 (Build 17763)
  • [ ] Windows 10 1903 (Build 18362)
  • [ ] Windows 10 1909 (Build 18363)
  • [ ] Windows 10 2004 (Build 19041)
  • [ ] Windows 10 20H2 (Build 19042)
  • [ ] Windows 10 21H1 (Build 19043)
  • [ ] Windows 10 21H2 (Build 19044)
  • [ ] Windows 10 22H2 (Build 19045)
  • [X] Windows 11 21H2 (Build 22000)
  • [ ] Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • [ ] Windows 10, version 1809 (Build 17763)
  • [ ] Windows 10, version 1903 (Build 18362)
  • [ ] Windows 10, version 1909 (Build 18363)
  • [ ] Windows 10, version 2004 (Build 19041)
  • [ ] Windows 10, version 2104 (Build 20348)
  • [ ] Windows 11, version 22H2 (Build 22000)
  • [ ] Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

No response

Device form factor

Desktop

Additional context

No response

Help us help you

No, I'm unable to contribute a solution.

guimafelipe avatar Jun 06 '24 18:06 guimafelipe

@Arlodotexe How should this be resolved? Expander is the parent, the ToggleButton is its child element for user to click on. Thanks to @marcelwgn, we've identified an issue we encountered during the migration to WCT 8 SettingsControls as this.

since clickable element must have accessibility name AFAIK, we should change the ToggleButton a11y name to something else?

https://github.com/CommunityToolkit/Windows/blob/605cd4369d0f46a0935af644282854798d6f317e/components/SettingsControls/src/SettingsExpander/SettingsExpander.xaml#L76-L86

https://github.com/CommunityToolkit/Windows/blob/605cd4369d0f46a0935af644282854798d6f317e/components/SettingsControls/src/SettingsExpander/SettingsExpander.xaml#L248-L266

0x5bfa avatar Mar 29 '25 21:03 0x5bfa