Windows icon indicating copy to clipboard operation
Windows copied to clipboard

SettingsExpander not showing title and description on Wasm/Uno

Open Arlodotexe opened this issue 1 year ago • 14 comments

The SettingsExpander is not showing title or description when running on Wasm.

image Originally posted by @lukasf in https://github.com/CommunityToolkit/Windows/discussions/383#discussioncomment-8987733

Second issue I noticed: SettingsExpander is still not working on any Uno targets: The header and icons are not shown. The control can be expanded and content is shown, but the header is completely empty.

You can also see this here: https://toolkitlabs.dev/

This was also the case in all older Uno WCT builds, so it is not a new bug. But since you now officially support Uno from WCT 8, it would be great if you can look into this.

Arlodotexe avatar Apr 04 '24 16:04 Arlodotexe

#321 might be related.

@martinzikmund does this ring a bell?

niels9001 avatar Apr 07 '24 17:04 niels9001

@niels9001 not really, it sounds like a data binding issue, we will have to investigate

MartinZikmund avatar Apr 10 '24 08:04 MartinZikmund

Any update on this @MartinZikmund?

This is one of the best new controls in WCT, it would be great if we can use it in Uno as well.

lukasf avatar May 10 '24 19:05 lukasf

We will make sure this is handled asap, most likely though the fix will have to be on the Uno Platform side, and we also need the WCT 8.1 update which will include Uno 5.x support 👍

MartinZikmund avatar May 14 '24 07:05 MartinZikmund

@MartinZikmund main branch should have the latest from Uno, would you be willing to help check these for us?

Arlodotexe avatar Jun 27 '24 16:06 Arlodotexe

Could this have been fixed with https://github.com/CommunityToolkit/Windows/pull/452 ?

Would someone be able to verify?

Youssef1313 avatar Jul 12 '24 07:07 Youssef1313

This is how it's rendering for me on https://toolkitlabs.dev/

image

Youssef1313 avatar Jul 12 '24 07:07 Youssef1313

This is how it's rendering for me on https://toolkitlabs.dev/

image

That's SettingsCard, not Expander. Could you try that to see if the issue is resolved? Maybe one of the recent Uno updates fixed the issue..

niels9001 avatar Jul 12 '24 11:07 niels9001

Ah sorry. Yes it's still broken it seems.

Youssef1313 avatar Jul 12 '24 11:07 Youssef1313

Hi 👋

I am looking into this issue from the Uno Platform side. Who can guide me in compiling and running the CommunityToolkit.Windows project/solution locally?

cc: @niels9001

ajpinedam avatar Aug 07 '24 13:08 ajpinedam

Hi 👋

I am looking into this issue from the Uno Platform side. Who can guide me in compiling and running the CommunityToolkit.Windows project/solution locally?

cc: @niels9001

@ajpinedam You can find our Quick Start guide here, otherwise we're available on GitHub and Discord if you run into issues!

Arlodotexe avatar Aug 22 '24 19:08 Arlodotexe

@ajpinedam any luck in investigating what might be going on here? Were you able to setup and run the projects from our repo?

michael-hawker avatar Oct 21 '24 16:10 michael-hawker

@michael-hawker This may have gotten fixed with latest Uno dev bits. Any chance you could double check?

Youssef1313 avatar Oct 21 '24 17:10 Youssef1313

@michael-hawker, as @Youssef1313 mentioned, this was fixed. Please use one of the latest dev versions of Uno whenever you can and validate the fix.

ajpinedam avatar Oct 22 '24 01:10 ajpinedam