SettingsCard missing invoke pattern

[AmelBawa-msft]

Describe the bug

Issue

Accessibility Insights reporting: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse." when using a SettingsCard that is clickable (IsClickEnabled=True).

Investigation

• SettingsCardAutomationPeer may possibly need to implement GetPatternCore(PatternInterface patternInterface) method.

protected override object GetPatternCore(PatternInterface patternInterface)
{
    return patternInterface == PatternInterface.Invoke ? this : base.GetPatternCore(patternInterface);
}

• Implement IInvokeProvider in the same class (since we're returning this).
• Or instead, maybe the SettingsCardAutomationPeer can inherit from ButtonBaseAutomationPeer?

Steps to reproduce

- Add a settings card

<controls:SettingsCard Header="Example" IsClickEnabled="True" />


- Run accessibility scan on the displayed card
- The following error is reported: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse."

Expected behavior

No errors

Screenshots

No response

Code Platform

• [ ] UWP
• [X] WinAppSDK / WinUI 3
• [ ] Web Assembly (WASM)
• [ ] Android
• [ ] iOS
• [ ] MacOS
• [ ] Linux / GTK

Windows Build Number

• [ ] Windows 10 1809 (Build 17763)
• [ ] Windows 10 1903 (Build 18362)
• [ ] Windows 10 1909 (Build 18363)
• [ ] Windows 10 2004 (Build 19041)
• [ ] Windows 10 20H2 (Build 19042)
• [ ] Windows 10 21H1 (Build 19043)
• [ ] Windows 10 21H2 (Build 19044)
• [ ] Windows 10 22H2 (Build 19045)
• [X] Windows 11 21H2 (Build 22000)
• [ ] Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

• [ ] Windows 10, version 1809 (Build 17763)
• [ ] Windows 10, version 1903 (Build 18362)
• [ ] Windows 10, version 1909 (Build 18363)
• [ ] Windows 10, version 2004 (Build 19041)
• [ ] Windows 10, version 2104 (Build 20348)
• [ ] Windows 11, version 22H2 (Build 22000)
• [ ] Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

[michael-hawker]

Thanks @AmelBawa-msft for the report and offering to help. We're working towards an 8.1 release in the near future. This seems like a simple fix, if you can open a PR this week, we can get look to get it into the upcoming release. FYI @niels9001