Windows icon indicating copy to clipboard operation
Windows copied to clipboard

Remove ThemeListener? And/or refactor?

Open michael-hawker opened this issue 2 years ago • 2 comments

ThemeListener doesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?

In either case, we should refactor to remove the call to EnqueueAsync for the DispatcherQueue Extensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:

https://github.com/CommunityToolkit/Windows/blob/be4577e5885a0a1e2b7f870e9551dcf8f057f1e5/components/Helpers/src/ThemeListener.cs#L110-L123

Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)

michael-hawker avatar Jul 11 '23 19:07 michael-hawker

Is themelistener still needed? I thought things like this got more and more built in...

Jay-o-Way avatar Dec 14 '23 20:12 Jay-o-Way

Again: could it be that something is blocking the basic functionality? (things like) Theme adaptation should be as native as possible and I am convinced there's no need for a complex solution.

Jay-o-Way avatar Jul 14 '24 19:07 Jay-o-Way