Windows icon indicating copy to clipboard operation
Windows copied to clipboard

Improve Samples in Media

Open Arlodotexe opened this issue 2 years ago • 10 comments

Arlodotexe avatar Jul 11 '23 16:07 Arlodotexe

In https://github.com/CommunityToolkit/Windows/pull/151, we ported all existing samples for the Media package from the 7.x sample app. This included samples for Shadows and EffectAnimations, but not for Brushes, Effects, or Pipelines.

We have users asking for samples on how to use things like TilesBrush, and so we should add them to the gallery. Additionally, for components without tests, this gives us a simple way to ensure these tools work as expected.

I've reopened this issue so we can add samples for the following:

  • [ ] Brushes
  • [ ] Effects
  • [ ] Pipelines

Arlodotexe avatar May 21 '24 00:05 Arlodotexe

FYI @TheJoeFin posted to ask about TilesBrush on BlueSky here - seems like it may be broken?

@Arlodotexe since we're probably not shipping 8.2 now until the new year, this could be a thing to spend a day and prop up again on our radar for any clean-up leading into it?

michael-hawker avatar Dec 18 '24 19:12 michael-hawker

Old Sample Pages that may have some of this code to move: https://github.com/CommunityToolkit/WindowsCommunityToolkit/tree/main/Microsoft.Toolkit.Uwp.SampleApp/SamplePages

michael-hawker avatar Feb 11 '25 17:02 michael-hawker

@erinpwoo is working on some improvements here.

michael-hawker avatar Feb 13 '25 17:02 michael-hawker

Almost done making the last set of changes for adding brush and pipeline samples. Will publish PR by EOD 2/21 @michael-hawker

erinpwoo avatar Feb 20 '25 19:02 erinpwoo

@erinpwoo if you have a sample for the TilesBrush coming as part of the brush samples you mention, that would be awesome. I'm asking because in the latest stable package (8.1.240916) the TilesBrush appears to be broken (seems not to render anything). Same in latest preview package 8.2.250129-preview2. That's on WinUI 3. The sample would provide evidence that it basically works and would help me spot what I'm doing differently and raise a targeted issue and repro steps if needed.

DaveAurionix avatar Feb 21 '25 21:02 DaveAurionix

@DaveAurionix yes, a TilesBrush sample is included. Link to PR: https://github.com/CommunityToolkit/Windows/pull/639

erinpwoo avatar Feb 21 '25 22:02 erinpwoo

@DaveAurionix yes, a TilesBrush sample is included. Link to PR: #639

Also, just validated the version this was built with is 8.2.1

erinpwoo avatar Feb 21 '25 22:02 erinpwoo

@erinpwoo have you switched to check WinUI 3 or just been running against UWP while developing?

michael-hawker avatar Feb 22 '25 00:02 michael-hawker

In #151, we ported all existing samples for the Media package from the 7.x sample app. This included samples for Shadows and EffectAnimations, but not for Brushes, Effects, or Pipelines.

We have users asking for samples on how to use things like TilesBrush, and so we should add them to the gallery. Additionally, for components without tests, this gives us a simple way to ensure these tools work as expected.

I've reopened this issue so we can add samples for the following:

  • [x] Brushes
  • [ ] Effects
  • [x] Pipelines

Samples for Pipelines and Brushes were added in #654, meaning only Effects samples are left to add.

Arlodotexe avatar Mar 26 '25 22:03 Arlodotexe