Tooling-Windows-Submodule icon indicating copy to clipboard operation
Tooling-Windows-Submodule copied to clipboard

[Clean-up] Centralize LangVersion to 10

Open michael-hawker opened this issue 3 years ago • 2 comments

We specify the LangVersion globally here:

https://github.com/CommunityToolkit/Labs-Windows/blob/60927b0c5975e1ccdbf52a899e044109aca1df1f/Windows.Toolkit.Common.props#L20

(Though maybe this should just be in the Directory.Build.props instead?)

We should update this to be explicitly 10.0.

We should also remove it from being duplicated in the two SG projects so we can manage it centrally:

https://github.com/CommunityToolkit/Labs-Windows/blob/63a00ffa3a4b69da3c68f5d090ad4e0de5eae350/common/CommunityToolkit.Labs.Core.SourceGenerators/CommunityToolkit.Labs.Core.SourceGenerators.csproj#L7

https://github.com/CommunityToolkit/Labs-Windows/blob/18fe7e7d929d6f4545eb7a095b0478ddffd0e3e9/common/CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay/CommunityToolkit.Labs.Core.SourceGenerators.XamlNamedPropertyRelay.csproj#L7

michael-hawker avatar May 05 '22 17:05 michael-hawker

@michael-hawker We now require at least C# 11 to use string literals, and have the option to enable C# 12. In a few places, we're specifying latest as the lang version.

Which do you think we should go with?

Arlodotexe avatar Jun 19 '23 19:06 Arlodotexe

Never use latest but instead specify a specific number.

mrlacey avatar Jun 19 '23 19:06 mrlacey