Tooling-Windows-Submodule icon indicating copy to clipboard operation
Tooling-Windows-Submodule copied to clipboard

Clean-up: Remove custom content linking and SourceAssets folder for loading of Sample Code, XAML, and Markdown

Open michael-hawker opened this issue 3 years ago • 2 comments

Related CommunityToolkit/Labs-Windows#37, CommunityToolkit/Labs-Windows#88

Improvement to workaround for this Uno issue: https://github.com/unoplatform/uno/issues/8618 - If the Uno issue gets resolved, this work doesn't need to be done and we can clean-up our existing workaround in the codebase.

@Arlodotexe talked to Jerome. He suggested instead of the glob we could use an inline task to help us with our desired copying heuristic: https://github.com/unoplatform/uno/blob/43efd99f67daade2e663e317989c3ab324a2c443/src/SolutionTemplate/Uno.ProjectTemplates.Dotnet/Uno.ProjectTemplates.Dotnet.csproj#L244

That way we can use the proper globs to grab the input files from the proper locations, but then have the task make sure the extra parent/relative path parts don't matter as it'll copy it to a consistent SourceAssets\ExperimentName.Sample\files location which matches the metadata we generate. That way all the apps should be able to load consistently regardless of where we're building the app / grabbing the files from, right?

Originally posted by @michael-hawker in https://github.com/CommunityToolkit/Labs-Windows/issues/130#issuecomment-1139180876

michael-hawker avatar Jun 06 '22 18:06 michael-hawker

This has been implemented in Uno. A workaround is no longer needed

Arlodotexe avatar Dec 15 '22 23:12 Arlodotexe

Another reason to work to fix this is that it's broken for individual experiment document viewing:

image

(i.e. everything I think is working when you compile the all solution, but if you just build an individual experiment and view the document preview in WASM, then it fails...)

michael-hawker avatar Mar 10 '23 23:03 michael-hawker