Microsoft.Toolkit.Win32 icon indicating copy to clipboard operation
Microsoft.Toolkit.Win32 copied to clipboard

Added symbols to XamlApplication package.

Open azchohfi opened this issue 4 years ago • 4 comments

Fixes #292

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Build or CI related changes

What is the current behavior?

No symbols at all for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

What is the new behavior?

Stripped and added symbols for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] Tested code with current supported SDKs
  • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
  • [ ] Sample in sample app has been added / updated (for bug fixes / features)
  • [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [X] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [X] Contains NO breaking changes

azchohfi avatar Oct 23 '20 19:10 azchohfi

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

ghost avatar Oct 23 '20 19:10 ghost

Can you make sure that the Xaml Islands repo still builds and that MSIX can still be compiled and run after this change?

ocalvo avatar Oct 28 '20 16:10 ocalvo

@azchohfi is there anything left before we merge this?

michael-hawker avatar Nov 18 '20 21:11 michael-hawker

Do not merge! This was not working.

azchohfi avatar Nov 18 '20 21:11 azchohfi