Maui
Maui copied to clipboard
Make sure Popup will set the Window at the Content
Description of Change
.NET MAUI has the concept of Window
inside some controls, when we implemented the Popup
we don't care (or this concept doesn't exist yet) about it, since it should be set automagically, but this isn't the case here because Popup
is an Element
so we need to help the framework to set it.
Linked Issues
- Fixes #629
From our Discord channel.
PR Checklist
- [x] Has a linked Issue, and the Issue has been
approved
(bug) orChampioned
(feature/proposal) - [x] Has tests (if omitted, state reason in description)
- [x] Has samples (if omitted, state reason in description)
- [x] Rebased on top of
main
at time of PR - [x] Changes adhere to coding standard
- [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pull/XYZ
Additional information
@brminnick thanks for testing on iOS, I'll give a try here, I hope the tooling works after this update
So... This is kinda funny, and I'm not sure if the bug is here or in .NET MAUI.
I downloaded the sample and added our .Core
and .Maui
projects. If I open the popup without a breaking point, the Lottie animation doesn't work, now if I set a break point and hit play it works.
So looks like a timing issue(?)
cc: @PureWeen
https://user-images.githubusercontent.com/20712372/194966835-50451a0f-ded4-4fda-a798-029fbe8f32c3.mp4
@pictos - Can we merge this since it fixes the bug on Android? As long as we keep the Bug open, we should be good right?
@brminnick yes, we can. I'll create a new issue related to the Window property, and link this PR to it. I'll also do a couple more changes on the PR during this week, I found some places where this can be improved.