Maui icon indicating copy to clipboard operation
Maui copied to clipboard

Published 20 hours ago • verified publisher icon CommunityToolkit

OnScreenSize markup extension

Open carolzbnbr opened this issue 2 years ago • 7 comments

Description of Change

First Pull Request for OnScreenSize markup extension.

Linked Issues

(https://github.com/CommunityToolkit/Maui/issues/425)

  • Fixes # First Pull Request for OnScreenSize markup extension.

PR Checklist

  • [X] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • [X] Has tests (if omitted, state reason in description)
  • [X] Has samples (if omitted, state reason in description)
  • [ ] Rebased on top of main at time of PR
  • [X] Changes adhere to coding standard
  • [ ] Documentation created or updated:

Additional information

First Pull Request for OnScreenSize markup extension.

carolzbnbr avatar Jul 27 '22 21:07 carolzbnbr

CLA assistant check
All CLA requirements met.

net-foundation-cla[bot] avatar Jul 27 '22 21:07 net-foundation-cla[bot]

Hi @VladislavAntonyuk thanks for reviewing my PR.

I wrote some responses on some of your suggestions. If you still find something does not make sense, let me know.

carolzbnbr avatar Jul 28 '22 08:07 carolzbnbr

Hi guys, just updated my draft PR, could you please review it?

carolzbnbr avatar Aug 03 '22 09:08 carolzbnbr

@carolzbnbr can you update your branch? I think that you opened the PR and didn't mark this checkbox, so we don't have write access to your code :/ Screen Shot 2022-08-10 at 20 10 56

pictos avatar Aug 10 '22 23:08 pictos

/dotnet format

pictos avatar Aug 11 '22 17:08 pictos

Hi @pictos + @carolzbnbr!

Any chance you're able to push this forward? I think it'd be great to include it in vNext, but it's now been marked stale because there has been no activity on the PR in the last 30 days.

brminnick avatar Oct 03 '22 21:10 brminnick

Hi @brminnick,

All issues raised by the team was fixed/implemented, but right now, the code is not passing on the CI Build, with some issues regarding code formating on Windows e MacOs, but I don't know how to fix it all at once, if you point me in the right direction I can fix it either this weekend or the next, and we can move forward with that.

Carol

carolzbnbr avatar Oct 04 '22 11:10 carolzbnbr

@carolzbnbr @pictos hi there is this still happening - totally appreciate your time! but just wondering

developer9969 avatar Oct 23 '22 08:10 developer9969

Hey @developer9969, yes we talked offline and she will open a new PR, in order to make possible this to move forward.

pictos avatar Oct 23 '22 18:10 pictos

@pictos thanks for the update!

developer9969 avatar Oct 24 '22 07:10 developer9969

Closing this PR as no progress has been made in 4 months, merge conflicts are unresolved, and this PR has prevented the core maintainers from editing it. Happy to reopen this PR if/when the author is available to complete it.

brminnick avatar Jan 09 '23 03:01 brminnick

Cant any of you Community gurus take over from where the author left off, this shows to be an awesome addition to the CTK

khayah23 avatar Mar 21 '23 20:03 khayah23