Maui icon indicating copy to clipboard operation
Maui copied to clipboard

Add BadgeView Control

Open tnassour opened this issue 3 years ago • 6 comments

Description of Change

Linked Issues

  • Fixes #

PR Checklist

  • [ ] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • [ ] Has tests (if omitted, state reason in description)
  • [ ] Has samples (if omitted, state reason in description)
  • [ ] Rebased on top of main at time of PR
  • [ ] Changes adhere to coding standard
  • [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls/XYZ

Additional information

tnassour avatar Mar 30 '22 21:03 tnassour

CLA assistant check
All CLA requirements met.

net-foundation-cla[bot] avatar Mar 30 '22 21:03 net-foundation-cla[bot]

Assigning Proposal Champion, @pictos

TheCodeTraveler avatar Mar 30 '22 21:03 TheCodeTraveler

Thanks @tnassour!

I just wanted to give you a heads up that we'll need you to open a PR for our Docs repo before we can merge this PR: https://github.com/MicrosoftDocs/CommunityToolkit

I know this is PR is still in Draft, so I've added the pending documentation and do not merge labels so that we don't forget about the docs 👍

TheCodeTraveler avatar Apr 02 '22 23:04 TheCodeTraveler

@tnassour is this PR something that you are still able to look at? We are on a feature freeze until .NET MAUI GAs later this month but I would like to see this go into the next version. If you are unable it's no problem, I would be happy to assist in getting it completed.

bijington avatar May 09 '22 11:05 bijington

@tnassour is this PR something that you are still able to look at? We are on a feature freeze until .NET MAUI GAs later this month but I would like to see this go into the next version. If you are unable it's no problem, I would be happy to assist in getting it completed.

@bijington i have done the modifications, it remains testing the sample solution for all of this. While building locally i am getting this error : 3>CSC : error CS0016: Could not write to output file 'C:\Apps\CommunityToolKit\Maui-fork\samples\CommunityToolkit.Maui.Sample\obj\GeneratedFiles\CommunityToolkit.Maui.SourceGenerators\CommunityToolkit.Maui.SourceGenerators.Generators.TextColorToGenerator\SearchBarTextColorTo_9e00a6b2-8703-4c7f-aaa2-32f7268ecea1.g.shared.cs' -- 'Could not find a part of the path 'C:\Apps\CommunityToolKit\Maui-fork\samples\CommunityToolkit.Maui.Sample\obj\GeneratedFiles\CommunityToolkit.Maui.SourceGenerators\CommunityToolkit.Maui.SourceGenerators.Generators.TextColorToGenerator\SearchBarTextColorTo_9e00a6b2-8703-4c7f-aaa2-32f7268ecea1.g.shared.cs'.'

can someone tell me how to fix this ?

tnassour avatar May 14 '22 14:05 tnassour

@tnassour is this PR something that you are still able to look at? We are on a feature freeze until .NET MAUI GAs later this month but I would like to see this go into the next version. If you are unable it's no problem, I would be happy to assist in getting it completed.

@bijington i have done the modifications, it remains testing the sample solution for all of this. While building locally i am getting this error : 3>CSC : error CS0016: Could not write to output file 'C:\Apps\CommunityToolKit\Maui-fork\samples\CommunityToolkit.Maui.Sample\obj\GeneratedFiles\CommunityToolkit.Maui.SourceGenerators\CommunityToolkit.Maui.SourceGenerators.Generators.TextColorToGenerator\SearchBarTextColorTo_9e00a6b2-8703-4c7f-aaa2-32f7268ecea1.g.shared.cs' -- 'Could not find a part of the path 'C:\Apps\CommunityToolKit\Maui-fork\samples\CommunityToolkit.Maui.Sample\obj\GeneratedFiles\CommunityToolkit.Maui.SourceGenerators\CommunityToolkit.Maui.SourceGenerators.Generators.TextColorToGenerator\SearchBarTextColorTo_9e00a6b2-8703-4c7f-aaa2-32f7268ecea1.g.shared.cs'.'

can someone tell me how to fix this ?

https://github.com/CommunityToolkit/Maui/issues/340#issuecomment-1081052363

VladislavAntonyuk avatar May 14 '22 14:05 VladislavAntonyuk

Closing PR as stale + abandoned

TheCodeTraveler avatar Sep 05 '22 15:09 TheCodeTraveler