Maui icon indicating copy to clipboard operation
Maui copied to clipboard

[BUG] Media Element Popup Dimensions

Open ne0rrmatrix opened this issue 9 months ago • 2 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

  • [x] I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

Small cosmetic issue with Popup and Media Element sample. Need to change the dimensions for media element in sample app when using popup as the control bar is cut off on right side and some buttons are not visible.

https://github.com/user-attachments/assets/b0516dbf-79b9-4b84-b8e3-897f5b605a10

Expected Behavior

Sample app should display controls and not clip on right side.

Steps To Reproduce

Run sample app from Community toolkit and choose media element and then click on popup button.

Link to public reproduction project repository

https://github.com/CommunityToolkit/Maui

Environment

- .NET MAUI CommunityToolkit: Current Main
- OS:Windows 10.0.19041.0
- .NET MAUI:9.0.60

Anything else?

Will have a PR up in a few minutes.

ne0rrmatrix avatar May 27 '25 01:05 ne0rrmatrix

Is this issue in the Sample App, or is the root cause in CommunityToolkit.Maui.MediaElement?

In the future, if you find an Issue in the Sample App, and the PR doesn't touch any of the libraries we publish, you can just open a PR; you don't need to open an Issue for a quick fix in the Sample App.

TheCodeTraveler avatar May 27 '25 02:05 TheCodeTraveler

The controls do not scale for size of picture on windows. I do not think the xaml controls ever scaled. I can look into modifying the xaml but for now it just makes sense to update sample app. To fix it in xaml would most likely require a complete rewrite of the xaml. It is based on MS app sdk and only includes what is required to draw the control. The only changes I made were to add the full screen button.

I remember this always being an issue and having to adjust this several times over the last few years.

ne0rrmatrix avatar May 27 '25 02:05 ne0rrmatrix