Maui icon indicating copy to clipboard operation
Maui copied to clipboard

Fix MediaElement not working on FlyoutPage in IOS/MAC Catalyst

Open ne0rrmatrix opened this issue 1 year ago • 4 comments

  • Bug fix

Description of Change

Support for Media Element on a FlyoutPage does not currently work on IOS. This adds support for it on IOS and Mac Catalyst.

Linked Issues

  • Fixes #2517

PR Checklist

  • [x] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • [ ] Has tests (if omitted, state reason in description)
  • [ ] Has samples (if omitted, state reason in description)
  • [x] Rebased on top of main at time of PR
  • [x] Changes adhere to coding standard
  • [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Windows and android already support playback on a FlyoutPage.

ne0rrmatrix avatar Feb 18 '25 13:02 ne0rrmatrix

@ne0rrmatrix How are you able to test + verify this fix works for a FlyoutPage?

This PR doesn't include an update to the sample app or additional unit tests. Any time we fix a bug, we should add a unit test, if possible, and add update the sample app to demonstrate it working (aka a Regression Test).

TheCodeTraveler avatar Feb 19 '25 19:02 TheCodeTraveler

I will update the PR with a sample and create tests. Ty.

ne0rrmatrix avatar Feb 19 '25 19:02 ne0rrmatrix

I tested against the provided sample showing isdue

ne0rrmatrix avatar Feb 19 '25 19:02 ne0rrmatrix

I have updated page extensions and tryGetCurrentPage as requested. I will start trying to figure out how to implement a FlyoutPage with sample app. Implementing the logic to handle a flyout page and a non shell app will be challenging.

Device specific tests for IOS/Mac to test this can be done. I am not sure if that is what you are looking for? If so I can do that. I hope I am not too off track with that line of reasoning.

ne0rrmatrix avatar Feb 20 '25 13:02 ne0rrmatrix