Maui icon indicating copy to clipboard operation
Maui copied to clipboard

[BUG] Clicking on full screen button while popup is open in Windows crashes the Sample application.

Open ne0rrmatrix opened this issue 9 months ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

  • [X] I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

Application crashes when clicking on full screen button while a popup of media element is visible.

Expected Behavior

Not sure. What do we want to do when we have created a popup with mediaElement when it is also in the background behind it? Do we want to remove the full screen button so it is not clickable when a popup is present? Not sure how we would do that off the top of my head. We would have to detect a popup becoming active and then hiding the full screen button? Maybe a solution?

Steps To Reproduce

  1. Build and run the sample app.
  2. Navigate to Media Element Page.
  3. Click on popup.
  4. Click on full screen button.

Link to public reproduction project repository

https://github.com/CommunityToolkit/Maui/tree/main/samples

Environment

- .NET MAUI CommunityToolkit:9.0.0
- OS: Windows 10 Build 10.0.19041.0
- .NET MAUI: 8.0.14
- .NET Maui CommunityToolkit MediaElement: 3.1.1

Sample

https://github.com/CommunityToolkit/Maui/assets/4167863/28571d9b-4823-4dd9-b6f5-68081d6f7b63

It looks like this is a weird edge case where it is possible to crash the app by clicking on a button. Full screen button should not be visible and also disabled while a popup is present. Or rewritten to handle full screen switch if popup is present.

ne0rrmatrix avatar May 09 '24 03:05 ne0rrmatrix

I might have an idea of how to fix that. Would you mind if I take a look at it? 🙂

bricefriha avatar May 22 '24 17:05 bricefriha

I might have an idea of how to fix that. Would you mind if I take a look at it? 🙂

Sure I would appreciate it if you could do that.

ne0rrmatrix avatar Jun 18 '24 03:06 ne0rrmatrix