Labs-Windows icon indicating copy to clipboard operation
Labs-Windows copied to clipboard

SettingsExpander

Open niels9001 opened this issue 2 years ago • 1 comments

This PR adds a new SettingsExpander control that allows developers to group certain settings in a coherent UI.

The SettingsExpander has a Header, Description, Icon and IsExpander property.

SettingsExpanderItems can be added - it enherites from a SettingsCard, so can be made clickable as well!

SettingsExpanderV2

See latest updates to plan here

niels9001 avatar Aug 01 '22 11:08 niels9001

FYI @niels9001 one of the tests is failing.

michael-hawker avatar Aug 05 '22 21:08 michael-hawker

@niels9001 I resolved the ToggleSwitch issue and it works both for card and expander in UWP/WindowsAppSDK:

image

Uses @rudyhuyn's attached resources style helper. Not sure if we have a better option than this, but it is nice from an elegance and maintenance perspective. And they'll be nice helpers in the future for other scenarios to boot. I know they've been eyed for the Toolkit inclusion for a while. @rudyhuyn please confirm here you're still good with these being contributed to the Toolkit.

michael-hawker avatar Oct 06 '22 23:10 michael-hawker

@niels9001 not sure what work you may be in the middle of, but you should run the XAML Styler script, eh? 😉

michael-hawker avatar Oct 06 '22 23:10 michael-hawker

@niels9001 think we're good now? Anything you want me to test before merging?

I did try out in Codespaces and there's some issues with the Expander. Not critical now (as we need to update Uno as well which may fix things) and I know we want to get in folks hands for more feedback, but another thing for us to track:

image

michael-hawker avatar Oct 12 '22 22:10 michael-hawker

Codespaces and there's some issues with the Expander. Not critical now (as we need to update Uno as well which may fix things) and I know we want to get in folks hands for more feedback, but another thing for

Ooooh.. that looks like Uno.Expander is using some sort of different resources?

I think we're good to go for now - I've added the known issues in the original post.

niels9001 avatar Oct 13 '22 08:10 niels9001