Graph-Controls icon indicating copy to clipboard operation
Graph-Controls copied to clipboard

MsalProvider constructor crashes unless you pass scopes

Open asklar opened this issue 1 year ago • 1 comments

https://github.com/CommunityToolkit/Graph-Controls/blob/d985141a317c96ad571bd9dd8097e38969b649d6/CommunityToolkit.Authentication.Msal/MsalProvider.cs#L63

the default value for scopes is null, but we unconditionally run the Select(...) on it. Fix would be to either not provide a default argument for scopes (since it's arguably needed), or at least use scopes?.Select(...) so that we don't end up with a null deref. note there's 2 ctors with this issue

asklar avatar Aug 15 '22 03:08 asklar

Hello asklar, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

ghost avatar Aug 15 '22 03:08 ghost