Recipes icon indicating copy to clipboard operation
Recipes copied to clipboard

lock.updateTimeout Error with CSS v1.7.5 and mashlib

Open bourgeoa opened this issue 1 year ago • 3 comments

Just tested with latest CSS v1.7.5

2025-01-23T09:05:02.217Z [SubdomainIdentifierStrategy] {Primary} debug: Identifier http://bob.localhost:8080/settings/dokieli.html is part of http://localhost:8080/
2025-01-23T09:05:02.218Z [BasicConditionsParser] {Primary} debug: Found the following conditions: {}
2025-01-23T09:05:02.218Z [RawBodyParser] {Primary} debug: HTTP request does not have a body, or its empty body is missing a Content-Type header
2025-01-23T09:05:02.218Z [AuthorizingHttpHandler] {Primary} verbose: Extracted credentials: {}
2025-01-23T09:05:02.219Z [AuthorizingHttpHandler] {Primary} verbose: Retrieved required modes: { http://bob.localhost:8080/settings/dokieli.html: read }
2025-01-23T09:05:02.219Z [OwnerPermissionReader] {Primary} debug: No authorization resources found that need an ownership check.
2025-01-23T09:05:02.219Z [WebAclReader] {Primary} debug: Retrieving permissions of an unknown agent
2025-01-23T09:05:02.219Z [WebAclReader] {Primary} debug: Searching ACL data for http://bob.localhost:8080/settings/dokieli.html
2025-01-23T09:05:02.220Z [WebAclReader] {Primary} debug: Trying to read the direct ACL document of http://bob.localhost:8080/settings/dokieli.html
2025-01-23T09:05:02.220Z [WebAclReader] {Primary} debug: Determining existence of  http://bob.localhost:8080/settings/dokieli.html.acl
2025-01-23T09:05:02.220Z [MemoryResourceLocker] {Primary} debug: Acquiring lock for http://bob.localhost:8080/settings/dokieli.html
2025-01-23T09:05:02.220Z [MemoryResourceLocker] {Primary} debug: Acquired lock for http://bob.localhost:8080/settings/dokieli.html. 1 locks active.
2025-01-23T09:05:02.220Z [FileSystemResourceLocker] {Primary} debug: Acquiring lock for http://bob.localhost:8080/settings/dokieli.html
Process is halting due to an uncaughtException with error Cannot read properties of undefined (reading 'updateTimeout')
/mnt/d/github/pivot/node_modules/proper-lockfile/lib/lockfile.js:104
    if (lock.updateTimeout) {
             ^

TypeError: Cannot read properties of undefined (reading 'updateTimeout')
    at updateLock (/mnt/d/github/pivot/node_modules/proper-lockfile/lib/lockfile.js:104:14)
    at /mnt/d/github/pivot/node_modules/proper-lockfile/lib/lockfile.js:167:17
    at FSReqCallback.oncomplete (node:fs:187:23)

Node.js v20.18.0

bourgeoa avatar Jan 23 '25 09:01 bourgeoa

That seems to be a new error unrelated to the previous ones. Are there fixed steps you have to reproduce this? At first glance this looks like something internally in the locking library itself which should never happen (and which we can't catch outside of it) so this could be annoying 😅

joachimvh avatar Jan 23 '25 09:01 joachimvh

The image below set the situation. I reproduced the error I was logged in http://bob.localhost:8080 clicked on /test.html (existing resource) inside /settings/ (this is a private folder)

Image

bourgeoa avatar Jan 23 '25 10:01 bourgeoa

You are right I reproduced the issue with CSS v1.7.4

bourgeoa avatar Jan 23 '25 10:01 bourgeoa