portfolio-html icon indicating copy to clipboard operation
portfolio-html copied to clipboard

Switch darkmode toggle icons display on click

Open Evavic44 opened this issue 2 years ago • 3 comments

The toggle icons show on both light and dark mode, set only one icon to display until clicked.

This will address the issue as stated in #107

Evavic44 avatar Jan 25 '22 12:01 Evavic44

@Evavic44 It's okay from my end.

Screenshot_20220125-214636

frankiefab100 avatar Jan 25 '22 20:01 frankiefab100

This issue is only visible to those that use a dark mode extension on their browser. Case example #107

This forces the page background to be dark and the text and icons light. And since the toggle icons are hidden based on their color, we'll need to opt for a more sophisticated way of hiding them, probably with JavaScript.

But thanks for reviewing, @frankiefab100 . We can implement this gradually as it is not a high-priority issue.

Evavic44 avatar Jan 25 '22 21:01 Evavic44

Alright

frankiefab100 avatar Jan 26 '22 00:01 frankiefab100