comfy-cli
comfy-cli copied to clipboard
Comfy-Org
TODO: Remove `click` dep when `typer` is compatible with it again.
This issue is a reminder to remove click at a later date. Presently it is required to be version pinned for the CLI to work at all.
The typer dependency recently broke with a change introduced by click 8.1.8 => 8.2.0. Until that it is smoothed out upstream, the workaround for comfy-cli was to add that click dep as a pinned dependency:
https://github.com/Comfy-Org/comfy-cli/blob/67f880dc12d714ee1f25056336327e31d4364dc4/pyproject.toml#L47
8.2.0 is considered a feature release, which as the release notes mention permit breaking changes 😕
This is the Click 8.2.0 feature release. A feature release may include new features, remove previously deprecated code, add new deprecation, or introduce potentially breaking changes.
The relevant PR to track for typer is here: https://github.com/fastapi/typer/pull/1145
@polarathene Would you be interested to help maintain comfy-cli? Feel free to send me an email [email protected]!
Would you be interested to help maintain comfy-cli?
I'm not that confident in Python, but apart from that I'm already stretched with my OSS commitments elsewhere, maybe in the future if I can spare the time. I would like to see comfy-cli to improve and stay healthy/useful, but most projects I've already been added or offered maintainer status I've rarely had time to contribute due to my current backlog 😅
I do plan to assist with pushing forward for an official ComfyUI container image, where I could probably assist with maintenance if interested.
As I explore that, I think a light-weight container with comfy-cli might also be interesting (it'd technically avoid these breakage concerns with the CLI install, and could offer a more secure runtime environment). If you'd be interested I could contribute a GH workflow + Dockerfile to automate builds and releases for that, it shouldn't be much of a maintenance burden once setup.