comfy-cli icon indicating copy to clipboard operation
comfy-cli copied to clipboard

removed patch that forced numpy<2 on windows

Open telamonian opened this issue 1 year ago • 1 comments
trafficstars

now that pytorch has updated beyond the broken 2.4 release, we can now remove the patch that forced numpy<2 on windows. We should test this on windows first before pulling this in

telamonian avatar Sep 13 '24 11:09 telamonian

This requires some caution. It's not just an issue with torch; there are cases where other dependency packages frequently used in custom nodes can cause serious problems, so testing is necessary.

If I remember correctly, numba was also one of the packages that caused problems.

ltdrdata avatar Sep 14 '24 04:09 ltdrdata

Thanks for this PR, we have implemented the changes described in it in a separate PR #297

bigcat88 avatar Jul 29 '25 11:07 bigcat88