ComfyUI_frontend
ComfyUI_frontend copied to clipboard
Loading workflows from image fails
Prerequisites
- [x] I am running the latest version of ComfyUI
- [x] I have searched existing issues to make sure this isn't a duplicate
- [x] I have tested with all custom nodes disabled (see how)
What happened?
Loading complex workflows saved with custom_nodes are not being correctly interpreted anymore since Frontend version 1.32.2 (according to #6561 also since 1.32.1).
I know that there's already an open issue for this, but the suggestes solution does not actually work and the suggested Merge-Request that is supposed to fix this issue is from June since it was a problem that already popped up in the past once.
When trying to load this image (workflow attached) it instead loads a basic comfyui workflow with just the prompts and a sampler instead of the advanced workflow.
When loading it in the last stable frontend release (1.28.8) it shows the full workflow as seen here:
While in the new 1.32.2 it shows a basic workflow with just the prompts and sampler settings filled out:
Dosubot suggested that the problem stems from values like is_changed being NaN instead of null or none. I checked older images and there was a node with a NaN value and was about to open a PR in the image-saver node's repo to sanitize NaN's before writing the data to the image - but upon deleting the affected node and saving an image again (the image attached at the top) i noticed that the issue still persists even without any NaN values in the metadata of the image.
Steps to Reproduce
- Download attached image(workflow)
- Open in frontend version 1.28.8 and the workflow loads correctly
- Open in frontend version 1.32.2 (or 1.32.1) and the workflow fails to load correctly
How is this affecting you?
Feature doesn't work as expected
ComfyUI Frontend Version
1.32.2
Browser
Firefox
Console Errors
Logs
Additional Context
I have not added any logs since there are no errors being thrown or anything different being shown other than the frontend version difference.
I have tried this in 2 different sterila environments - once with all custom nodes required for the workflow installed and once without any nodes installed and just a clean comfyui installation. Both on v.1.28.8 and v.1.32.2
┆Issue is synchronized with this Notion page by Unito