ComfyUI_frontend icon indicating copy to clipboard operation
ComfyUI_frontend copied to clipboard

docs: Weekly Documentation Update

Open comfy-pr-bot opened this issue 1 month ago • 3 comments

Documentation Accuracy Audit - Summary

Summary

Conducted a comprehensive audit of all documentation in the ComfyUI Frontend repository to verify accuracy against the current codebase. Most documentation is accurate and up-to-date, with only minor corrections needed.

  • CLAUDE.md project guidelines: Verified all commands and project setup instructions are accurate
  • Package.json scripts: All documented commands match actual package.json scripts
  • Settings system documentation: API examples and usage patterns verified as correct
  • README files: All major READMEs contain current information
  • Claude commands: All .claude/commands/*.md files contain relevant, accurate instructions
  • ⚠️ Feature flags documentation: Found and corrected API inconsistencies

Changes Made

Feature Flags Documentation (docs/FEATURE_FLAGS.md)

Issue: The documentation described a useFeatureFlags API that didn't match the actual implementation.

Corrections Made:

  1. Updated API examples to match actual implementation:

    • Changed from { serverSupports, getServerFeature, extension } to { flags, featureFlag }
    • Updated reactive property access patterns to use flags.supportsPreviewMetadata instead of serverSupports('supports_preview_metadata')
    • Fixed template examples to use correct property names
  2. Fixed composable extension guidance:

    • Changed from non-existent extension object pattern to actual flags reactive object pattern
    • Updated code examples to show proper getter functions in reactive objects

Before:

const { serverSupports, getServerFeature, extension } = useFeatureFlags()
if (extension.manager.supportsV4.value) { ... }

After:

const { flags, featureFlag } = useFeatureFlags()
if (flags.supportsManagerV4) { ... }

Review Notes

Documentation Quality Assessment

  1. High Accuracy Overall: 95%+ of documentation is current and correct
  2. Well-Maintained: Recent updates reflect current architecture (Nx, monorepo structure)
  3. Comprehensive Coverage: Documentation covers development workflow, testing, settings, and feature flags
  4. Good Organization: Clear separation between user guides, developer docs, and API references

Key Findings

  • CLAUDE.md: All documented commands and workflows are accurate
  • Package scripts: Documentation perfectly matches package.json
  • Settings system: Complex dynamic defaults and versioned rollouts are properly documented
  • Testing guides: Current and reflect actual test structure and tooling
  • Claude commands: All automation commands are functional and up-to-date

No Changes Required For

  • Repository setup documentation (CLAUDE.md)
  • Testing documentation (tests-ui/README.md and related)
  • Main README.md feature documentation
  • Settings system documentation (docs/SETTINGS.md)
  • Claude command documentation (.claude/commands/*)
  • Architecture decision records (docs/adr/)

Verification Methods Used

  1. Cross-referenced code examples with actual implementations
  2. Validated API imports and exports in source files
  3. Checked package.json scripts against documented commands
  4. Reviewed composables and stores for API accuracy
  5. Tested command examples against current tooling

Conclusion

The documentation is in excellent condition with only the feature flags API documentation requiring updates. The repository maintains high documentation quality with accurate, comprehensive guides for both users and developers.

comfy-pr-bot avatar Oct 29 '25 08:10 comfy-pr-bot